[newlib-cygwin] Cygwin: ldd: Also look for not found DLLs when exit status is non-zero
Jon TURNEY
jturney@sourceware.org
Fri Sep 11 12:27:27 GMT 2020
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=f4a1b6ae182aaebd5b5a69f3f31ef633bc174464
commit f4a1b6ae182aaebd5b5a69f3f31ef633bc174464
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date: Mon Sep 7 16:24:39 2020 +0100
Cygwin: ldd: Also look for not found DLLs when exit status is non-zero
If the process exited with e.g. STATUS_DLL_NOT_FOUND, also process the
file to look for not found DLLs.
(We currently only do this when a STATUS_DLL_NOT_FOUND exception occurs,
which I haven't managed to observe)
This still isn't 100% correct, as it only examines the specified file
for missing DLLs, not recursively on the DLLs it depends upon.
Diff:
---
winsup/utils/ldd.cc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/winsup/utils/ldd.cc b/winsup/utils/ldd.cc
index e1af99e12..1e1863c1c 100644
--- a/winsup/utils/ldd.cc
+++ b/winsup/utils/ldd.cc
@@ -407,6 +407,8 @@ report (const char *in_fn, bool multiple)
}
break;
case EXIT_PROCESS_DEBUG_EVENT:
+ if (ev.u.ExitProcess.dwExitCode != 0)
+ process_fn = fn_win;
print_and_exit:
print_dlls (&dll_list, isdll ? fn_win : NULL, process_fn);
exitnow = true;
More information about the Cygwin-cvs
mailing list