src/winsup/cygwin ChangeLog autoload.cc autolo ...

[Christopher Faylor]

On Thu, May 03, 2001 at 07:54:27PM +0400, egor duda wrote:
>Hi!
>
>Thursday, 03 May, 2001 Christopher Faylor cgf@redhat.com wrote:
>
>>>>2001-05-03  Egor Duda  <deo@logos-m.ru>
>>>>
>>>>        * fhandler_socket.cc (set_connect_secret): Use /dev/random to
>>>>        generate secret cookie.
>>>
>>>What happens to the buf that you allocate here?  It looks like a memory
>>>leak.
>
>CF> Just to be a little clearer:  It looks like a memory leak in execed proceses.
>CF> ccalloced memory is copied to execed processes.
>
>ok. take 2.

That looks better but I would prefer malloc/free rather than
malloc/delete.

Alternatively, you could make entropy_source part of fhandler_socket,
ccalloc it, and cfree it in fhandler_socket destruction.  I guess this
isn't right, though, since that would end up performing this operation
once per every socket.

cgf